Update build src toolchain & Wiremock Dependency #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @zjdaniels1985 on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
HiveMQ Documentation should utilize the Java 11 Toolchain as per documentation. Wiremock version 3.0.1 has CVE's. The latest version of Wiremock resolves these vulnerabilities.
Wiremock project team are no longer updating jre8 version of Wiremock as per their Github project page documentation.
Maven Central artifact relocation:
Wiremock Version 3.0.1 CVE's:
Resolves #506
Changes
buildSrc updated to Java 11 Toolchain.
Wiremock updated to version 3.9.2 resolving vulnerabilities and removing the requirement for JRE-8. Wiremock implentation updates not required with latest version (3.9.2) under the new Maven Central package org.wiremock.
All tests are passing locally.